kubernetes_persistent_volume resource should support storage_class_name #72
Conversation
…storage_class_name` param
|
I believe adding this feature will fix the issues I mentioned in #74. |
|
I'm generally 👍 on this, it's less broken and more in-line with the recommendations in https://kubernetes.io/docs/concepts/storage/persistent-volumes/#writing-portable-configuration I have one concern about backwards-compatibility: What would happen if a user has dynamically created a PV with a PVC claim using the current default storage_class_name value? Does Terraform maintain enough state to realize that the PV and PVC don't need to be created/updated? The behavior of the default value of storageclassname in a PVC can be complicated, and may need some follow-up work: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class-1 |
| @@ -29,6 +29,7 @@ resource "kubernetes_persistent_volume" "example" { | |||
| volume_path = "/absolute/path" | |||
| } | |||
| } | |||
| storage_class_name = "standard" | |||
There was a problem hiding this comment.
This should probably be left out of the example resource, because it should be left empty by default.
|
I'd also mark this as a bugfix, not just an enhancement. You can't currently create a PVC in Terraform for PV. |
|
Could we please get this PR merged? Deploying apps with state currently is pretty much impossible with this provider |
|
@coderfi Would you mind rebasing? |
|
Is anyone motivated to merge this? or has there been an alternative solution merged into master? This is a huge issue for people attempting to adopt terraform for kubernetes |
|
Glad this was addressed in #111. Sorry for not keeping up with this PR. |
ghost
locked and limited conversation to collaborators
This parameter is optional.
Allows for the fix described in https://stackoverflow.com/a/44891419